Code review comment for lp:~jcsackett/launchpad/edit-icons-permissions

Revision history for this message
Richard Harding (rharding) wrote :

Looks ok. I'd rather the editable was an ATTR that had the valueFn set to pull the value out of the LP.cache, but then you could easily over ride it manually by setting that attribute for testing and manual changes. In this way the cache is static and untouched. That might not be possible here if these YUI objects aren't full base class extensions so just take it as a suggestion vs a please fix.

review: Approve

« Back to merge proposal