Code review comment for lp:~jcsackett/launchpad/bug-expiration-doesnt-oops

Revision history for this message
j.c.sackett (jcsackett) wrote :

> The raise is there because we shouldn't swallow exceptions unless we have
> corrected the error - and we haven't. It may not be needed (I haven't checked
> to see if that was the last line in the script) but its safer to assume its
> needed - or put a comment in on why its not, as catchall excepts really are,
> well, the exception.

You're right about the raise, and I thought I had put that in; it (and the other changes) have been made and pushed up.

« Back to merge proposal