Merge lp:~jcsackett/launchpad/blueprints-in-ui-not-specification-2 into lp:launchpad

Proposed by j.c.sackett
Status: Merged
Approved by: j.c.sackett
Approved revision: no longer in the source branch.
Merged at revision: 16315
Proposed branch: lp:~jcsackett/launchpad/blueprints-in-ui-not-specification-2
Merge into: lp:launchpad
Diff against target: 54 lines (+9/-9)
1 file modified
lib/lp/registry/enums.py (+9/-9)
To merge this branch: bzr merge lp:~jcsackett/launchpad/blueprints-in-ui-not-specification-2
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+136213@code.launchpad.net

Commit message

Change mentions of "specification" to "blueprint" in the descriptions in SpecificationSharingPolicy, since they show in the UI.

Description of the change

Summary
=======
We updated the UI on +sharing to say "Blueprint sharing policy" rather than
"Specification sharing policy", but the enum descriptions for the policy
still reference specifications. Since these descriptions are shown in the UI
along with the "Blueprint sharing policy" label, the descriptions should be
updated as well.

Preimp
======
None.

Implementation
==============
Changed all mentions of "specification" to "blueprint" in the sharing policy
enum.

QA
==
Ensure the display is correct in +sharing.

LoC
===
Part of private projects.

Lint
====

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/registry/enums.py

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

Good words are good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/registry/enums.py'
--- lib/lp/registry/enums.py 2012-11-16 20:55:48 +0000
+++ lib/lp/registry/enums.py 2012-11-27 15:18:35 +0000
@@ -144,42 +144,42 @@
144 PUBLIC = DBItem(1, """144 PUBLIC = DBItem(1, """
145 Public145 Public
146146
147 Specifications are public.147 Blueprints are public.
148 """)148 """)
149149
150 PUBLIC_OR_PROPRIETARY = DBItem(2, """150 PUBLIC_OR_PROPRIETARY = DBItem(2, """
151 Public, can be proprietary151 Public, can be proprietary
152152
153 New specifications are public, but can be made proprietary later.153 New blueprints are public, but can be made proprietary later.
154 """)154 """)
155155
156 PROPRIETARY_OR_PUBLIC = DBItem(3, """156 PROPRIETARY_OR_PUBLIC = DBItem(3, """
157 Proprietary, can be public157 Proprietary, can be public
158158
159 New specifications are proprietary, but can be made public later. Only159 New blueprints are proprietary, but can be made public later. Only
160 people who can see the project's proprietary information can create160 people who can see the project's proprietary information can create
161 new specifications.161 new blueprints.
162 """)162 """)
163163
164 PROPRIETARY = DBItem(4, """164 PROPRIETARY = DBItem(4, """
165 Proprietary165 Proprietary
166166
167 Specifications are always proprietary. Only people who can see the167 Blueprints are always proprietary. Only people who can see the
168 project's proprietary information can create new specifications.168 project's proprietary information can create new blueprints.
169 """)169 """)
170170
171 EMBARGOED_OR_PROPRIETARY = DBItem(5, """171 EMBARGOED_OR_PROPRIETARY = DBItem(5, """
172 Embargoed, can be proprietary172 Embargoed, can be proprietary
173173
174 New specifications are embargoed, but can be made proprietary later.174 New blueprints are embargoed, but can be made proprietary later.
175 Only people who can see the project's proprietary information can175 Only people who can see the project's proprietary information can
176 create new specifications.176 create new blueprints.
177 """)177 """)
178178
179 FORBIDDEN = DBItem(6, """179 FORBIDDEN = DBItem(6, """
180 Forbidden180 Forbidden
181181
182 No new specifications may be created, but existing specifications may182 No new blueprints may be created, but existing blueprints may
183 still be updated.183 still be updated.
184 """)184 """)
185185