juju-gui

Merge lp:~jcsackett/juju-gui/make-it-pretty into lp:juju-gui/experimental

  1. make-it-pretty
  2. Merge into trunk
Proposed by j.c.sackett
Status: Merged
Merged at revision: 757
Proposed branch: lp:~jcsackett/juju-gui/make-it-pretty
Merge into: lp:juju-gui/experimental
Diff against target: 71 lines (+35/-9)
2 files modified
lib/views/browser/charm-full.less (+3/-0)
lib/views/browser/sharing-widget.less (+32/-9)
To merge this branch: bzr merge lp:~jcsackett/juju-gui/make-it-pretty
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+171158@code.launchpad.net

Description of the change

Styles the share widget

This adds Huw's sharing work to the sharing widget, finishing the structure of
the widget.

https://codereview.appspot.com/10495045/

To post a comment you must log in.
Revision history for this message
j.c.sackett (jcsackett) wrote :

Reviewers: mp+171158_code.launchpad.net,

Message:
Please take a look.

Description:
Styles the share widget

This adds Huw's sharing work to the sharing widget, finishing the
structure of
the widget.

https://code.launchpad.net/~jcsackett/juju-gui/make-it-pretty/+merge/171158

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/10495045/

Affected files:
   A [revision details]
   M lib/views/browser/charm-full.less
   M lib/views/browser/sharing-widget.less

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: lib/views/browser/charm-full.less
=== modified file 'lib/views/browser/charm-full.less'
--- lib/views/browser/charm-full.less 2013-06-04 16:13:15 +0000
+++ lib/views/browser/charm-full.less 2013-06-24 06:01:04 +0000
@@ -26,6 +26,9 @@
      p {
          max-width: 66.666%;
      }
+ .yui3-sharingwidget li {
+ max-width: 100%;
+ }
      .provider-warning {
          height: 20px;
          margin-top: -1px;

Index: lib/views/browser/sharing-widget.less
=== modified file 'lib/views/browser/sharing-widget.less'
--- lib/views/browser/sharing-widget.less 2013-06-20 18:40:46 +0000
+++ lib/views/browser/sharing-widget.less 2013-06-24 06:01:04 +0000
@@ -3,21 +3,44 @@
  }

  .yui3-sharingwidget {
- background: @charm-panel-background-color;
- border: 1px solid @bws-border;
+ position: absolute;
+ padding-top: 15px;

      li {
- width: 45px;
- padding-top: 5px;
- padding-bottom: 5px;
- border-top: 1px solid @bws-border;
+ border-top: 1px solid #d4d4d4;

- #sharing-first {
+ &#sharing-first {
              border-top: none;
          }
-
          a {
- margin-left: 15px;
+ display: block;
+ padding: 20px;
+
+ &:hover {
+ background-color: #eee;
+ }
          }
      }
+ .yui3-sharingwidget-content {
+ position: relative;
+ z-index: 5;
+ background-color: #f9f9f9;
+ box-shadow: 0 5px 10px rgba(0, 0, 0, 0.2);
+ border-radius: 5px;
+ }
+ &:after {
+ content: ' ';
+ position: absolute;
+ display: block;
+ left: 50%;
+ top: 7px;
+ width: 20px;
+ height: 20px;
+ margin-left: -10px;
+ background-color: #f9f9f9;
+ transform: rotate(45deg);
+ -webkit-transform: rotate(45deg);
+ -moz-transform: rotate(45deg);
+ box-shadow: 0 5px 10px rgba(0, 0, 0, 0.2);
+ }
  }

Revision history for this message
Gary Poster (gary) wrote :

LGTM. Thanks!

https://codereview.appspot.com/10495045/

Revision history for this message
j.c.sackett (jcsackett) wrote :

LGTM, qa's ok.

https://codereview.appspot.com/10495045/

Revision history for this message
j.c.sackett (jcsackett) wrote :

*** Submitted:

Styles the share widget

This adds Huw's sharing work to the sharing widget, finishing the
structure of
the widget.

R=gary.poster
CC=
https://codereview.appspot.com/10495045

https://codereview.appspot.com/10495045/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/views/browser/charm-full.less'
2--- lib/views/browser/charm-full.less 2013-06-04 16:13:15 +0000
3+++ lib/views/browser/charm-full.less 2013-06-24 19:45:43 +0000
4@@ -26,6 +26,9 @@
5 p {
6 max-width: 66.666%;
7 }
8+ .yui3-sharingwidget li {
9+ max-width: 100%;
10+ }
11 .provider-warning {
12 height: 20px;
13 margin-top: -1px;
14
15=== modified file 'lib/views/browser/sharing-widget.less'
16--- lib/views/browser/sharing-widget.less 2013-06-20 18:40:46 +0000
17+++ lib/views/browser/sharing-widget.less 2013-06-24 19:45:43 +0000
18@@ -3,21 +3,44 @@
19 }
20
21 .yui3-sharingwidget {
22- background: @charm-panel-background-color;
23- border: 1px solid @bws-border;
24+ position: absolute;
25+ padding-top: 15px;
26
27 li {
28- width: 45px;
29- padding-top: 5px;
30- padding-bottom: 5px;
31- border-top: 1px solid @bws-border;
32+ border-top: 1px solid #d4d4d4;
33
34- #sharing-first {
35+ &#sharing-first {
36 border-top: none;
37 }
38-
39 a {
40- margin-left: 15px;
41+ display: block;
42+ padding: 20px;
43+
44+ &:hover {
45+ background-color: #eee;
46+ }
47 }
48 }
49+ .yui3-sharingwidget-content {
50+ position: relative;
51+ z-index: 5;
52+ background-color: #f9f9f9;
53+ box-shadow: 0 5px 10px rgba(0, 0, 0, 0.2);
54+ border-radius: 5px;
55+ }
56+ &:after {
57+ content: ' ';
58+ position: absolute;
59+ display: block;
60+ left: 50%;
61+ top: 7px;
62+ width: 20px;
63+ height: 20px;
64+ margin-left: -10px;
65+ background-color: #f9f9f9;
66+ transform: rotate(45deg);
67+ -webkit-transform: rotate(45deg);
68+ -moz-transform: rotate(45deg);
69+ box-shadow: 0 5px 10px rgba(0, 0, 0, 0.2);
70+ }
71 }

Subscribers

People subscribed via source and target branches