LGTM however I'm a little concerned about the duplication of code - possibly create a follow-up to normalize this stuff?
https://codereview.appspot.com/13092044/diff/1/app/subapps/browser/views/minimized.js File app/subapps/browser/views/minimized.js (right):
https://codereview.appspot.com/13092044/diff/1/app/subapps/browser/views/minimized.js#newcode52 app/subapps/browser/views/minimized.js:52: Binds the viewmode control events to navigation. This code appears to be duplicated in other parts of the application - can it not be split out into a mixin and then mixed into all classes which need it?
https://codereview.appspot.com/13092044/
« Back to merge proposal
LGTM however I'm a little concerned about the duplication of code -
possibly create a follow-up to normalize this stuff?
https:/ /codereview. appspot. com/13092044/ diff/1/ app/subapps/ browser/ views/minimized .js browser/ views/minimized .js (right):
File app/subapps/
https:/ /codereview. appspot. com/13092044/ diff/1/ app/subapps/ browser/ views/minimized .js#newcode52 browser/ views/minimized .js:52: Binds the viewmode control
app/subapps/
events to navigation.
This code appears to be duplicated in other parts of the application -
can it not be split out into a mixin and then mixed into all classes
which need it?
https:/ /codereview. appspot. com/13092044/