Code review comment for lp:~jcsackett/juju-gui/browse-will-not-open-from-minimized

Revision history for this message
Richard Harding (rharding) wrote :

LGTM with the test fixes to use done() vs the assert that might not get
hit based on the speed of the test run.

https://codereview.appspot.com/13092044/diff/1/test/test_browser_app.js
File test/test_browser_app.js (right):

https://codereview.appspot.com/13092044/diff/1/test/test_browser_app.js#newcode87
test/test_browser_app.js:87: it('can toggle back to oldviewmode via the
toggle', function() {
shouldn't these take done and then call it in the
view.on('viewNavigate')? Does this really assert anything or just pass
through? This is the same on all three tests.

https://codereview.appspot.com/13092044/

« Back to merge proposal