Code review comment for ~jcastets/cloud-init:scaleway-datasource

Revision history for this message
Scott Moser (smoser) wrote :

I approve of this at this point.
The use of urllib3 through requests could be a problem in the future, but
should not cause any regression potential here as this is a new
datasource.

I plan on adding the additional changes at
 http://paste.ubuntu.com/25114217/

Just for our future reference / context.

« Back to merge proposal