Code review comment for ~jcastets/cloud-init:scaleway-datasource
Revision history for this message
| Julien Castets (jcastets) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Some comments inline. mostly questions.
Everything should be fixed. I can rebase my commits into one if you want me to.
> Would it be easier for you to use requests directly rather than going through
> urlhelper ?
I'd prefer not to. url_helper is doing some logging, sets the user-agent, gracefully handles SSL errors... even if it seems hackish, using url_helper.readurl is IMO the best way to do.