Code review comment for ~jcastets/cloud-init:fix-net-cfg

Revision history for this message
Scott Moser (smoser) wrote :

My only comments here is with respect to dhcp.
If the configuration type was dhcp, then i think its more correct to not include 'address', as most dhcp stanzas for network config are not going to have an address so that is at very least confusing.

How about this diff :
  http://paste.ubuntu.com/24587345/

« Back to merge proposal