Merge lp:~jc.redoutey/libmemcached/mget_execute into lp:~tangent-org/libmemcached/trunk

[JC Redoutey]

[JC Redoutey (jc.redoutey)]

New version with the changes asked
cheers

[Brian Aker (brianaker)]

I am looking at porting this forward right now.

A couple of things:

1) When you modify memcached_st to add a new member, you need to make sure it is initialized correctly.
2) Mixing int with size_t will just cause porting issues (this was in function.c).

I need to give a better example of how to use just one server during a test.

Thanks for this work, I am sorry I didn't get it in faster.

Cheers,
   -Brian

=== modified file 'libmemcached/memcached.h'
--- libmemcached/memcached.h	2009-11-09 19:19:38 +0000
+++ libmemcached/memcached.h	2009-11-30 21:30:22 +0000
@@ -75,6 +75,7 @@
 
 struct memcached_st {
   uint8_t purging;
+  uint8_t processing_input;
   bool is_allocated;
   uint8_t distribution;
   uint8_t hash;
 
=== modified file 'libmemcached/memcached_io.c'
--- libmemcached/memcached_io.c	2009-10-14 11:40:42 +0000
+++ libmemcached/memcached_io.c	2009-11-30 21:30:22 +0000
@@ -120,10 +120,15 @@
      */
     memcached_callback_st cb= *ptr->root->callbacks;
 
+    ptr->root->processing_input = 1;
+
     char buffer[MEMCACHED_DEFAULT_COMMAND_SIZE];
     memcached_return error;
     error= memcached_response(ptr, buffer, sizeof(buffer),
                               &ptr->root->result);
+
+    ptr->root->processing_input = 0;
+
     if (error == MEMCACHED_SUCCESS)
     {
       for (unsigned int x= 0; x < cb.number_of_callback; x++)
 
=== modified file 'libmemcached/memcached_response.c'
--- libmemcached/memcached_response.c	2009-10-06 10:48:57 +0000
+++ libmemcached/memcached_response.c	2009-11-30 21:30:22 +0000
@@ -44,7 +44,7 @@
                                     memcached_result_st *result)
 {
   /* We may have old commands in the buffer not set, first purge */
-  if (ptr->root->flags & MEM_NO_BLOCK)
+  if ((ptr->root->flags & MEM_NO_BLOCK) && (!ptr->root->processing_input))
     (void)memcached_io_write(ptr, NULL, 0, 1);
 
   /*
 
=== modified file 'tests/function.c'
--- tests/function.c	2009-11-27 17:05:51 +0000
+++ tests/function.c	2009-11-30 21:30:22 +0000
@@ -3922,7 +3922,7 @@
 }
 
 #ifdef HAVE_LIBMEMCACHEDUTIL
-static void* connection_release(void *arg) 
+static void* connection_release(void *arg)
 {
   struct {
     memcached_pool_st* pool;
@@ -4169,7 +4169,7 @@
     rc= memcached_set(memc, keys[x], len[x], "1", 1, 0, 0);
     test_truth(rc == MEMCACHED_SUCCESS);
   }
-  
+
   memcached_quit(memc);
 
   for (int x=0; x< 7; ++x) {
@@ -5391,6 +5391,88 @@
   return TEST_SUCCESS;
 }
 
+
+
+
+/*
+ * Test that ensures mget_execute does not end into recursive calls that finally fails
+ */
+static test_return_t regression_bug_490486(memcached_st *memc)
+{
+
+  memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_BINARY_PROTOCOL,1);
+  memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_NO_BLOCK,1);
+  memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_POLL_TIMEOUT,1000);
+  memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_SERVER_FAILURE_LIMIT,1);
+  memcached_behavior_set(memc, MEMCACHED_BEHAVIOR_RETRY_TIMEOUT,3600);
+
+  /*
+   * I only want to hit _one_ server so I know the number of requests I'm
+   * sending in the pipeline.
+   */
+  uint32_t number_of_hosts= memc->number_of_hosts;
+  memc->number_of_hosts= 1;
+  int max_keys= 20480;
+
+
+  char **keys= calloc((size_t)max_keys, sizeof(char*));
+  size_t *key_length=calloc((size_t)max_keys, sizeof(size_t));
+
+  /* First add all of the items.. */
+  char blob[1024] = {0};
+  memcached_return rc;
+  for (int x= 0; x < max_keys; ++x)
+  {
+    char k[251];
+    key_length[x]= (size_t)snprintf(k, sizeof(k), "0200%u", x);
+    keys[x]= strdup(k);
+    assert(keys[x] != NULL);
+    rc= memcached_set(memc, keys[x], key_length[x], blob, sizeof(blob), 0, 0);
+    assert(rc == MEMCACHED_SUCCESS || rc == MEMCACHED_BUFFERED);
+  }
+
+  /* Try to get all of them with a large multiget */
+  unsigned int counter= 0;
+  memcached_execute_function callbacks[1]= { [0]= &callback_counter };
+  rc= memcached_mget_execute(memc, (const char**)keys, key_length,
+                             (size_t)max_keys, callbacks, &counter, 1);
+
+  assert(rc == MEMCACHED_SUCCESS);
+  char* the_value = NULL;
+  char the_key[MEMCACHED_MAX_KEY];
+  size_t the_key_length;
+  size_t the_value_length;
+  uint32_t the_flags;
+
+  do {
+    the_value = memcached_fetch(memc, the_key, &the_key_length, &the_value_length, &the_flags, &rc);
+    if((the_value!= NULL) && (rc == MEMCACHED_SUCCESS))
+    {
+      ++counter;
+      free(the_value);
+    }
+
+  }while( (the_value!= NULL) && (rc == MEMCACHED_SUCCESS));
+
+
+  assert(rc == MEMCACHED_END);
+
+  /* Verify that we got all of the items */
+  assert(counter == (unsigned int)max_keys);
+
+  /* Release all allocated resources */
+  for (int x= 0; x < max_keys; ++x)
+    free(keys[x]);
+  free(keys);
+  free(key_length);
+
+  memc->number_of_hosts= number_of_hosts;
+  return TEST_SUCCESS;
+}
+
+
+
+
 test_st udp_setup_server_tests[] ={
   {"set_udp_behavior_test", 0, set_udp_behavior_test},
   {"add_tcp_server_udp_client_test", 0, add_tcp_server_udp_client_test},
@@ -5567,6 +5649,7 @@
   {"lp:442914", 1, regression_bug_442914 },
   {"lp:447342", 1, regression_bug_447342 },
   {"lp:463297", 1, regression_bug_463297 },
+  {"lp:490486", 1, regression_bug_490486 },
   {0, 0, 0}
 };