Ubuntu theme

Merge lp:~jbicha/ubuntu-themes/fix-gtk322-warnings into lp:ubuntu-themes

  1. fix-gtk322-warnings
  2. Merge into trunk
Proposed by Jeremy Bícha
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 521
Merged at revision: 521
Proposed branch: lp:~jbicha/ubuntu-themes/fix-gtk322-warnings
Merge into: lp:ubuntu-themes
Diff against target: 99 lines (+13/-11)
4 files modified
Ambiance/gtk-3.20/apps/nautilus.css (+3/-3)
Ambiance/gtk-3.20/gtk-widgets.css (+4/-3)
Radiance/gtk-3.20/apps/nautilus.css (+2/-2)
Radiance/gtk-3.20/gtk-widgets.css (+4/-3)
To merge this branch: bzr merge lp:~jbicha/ubuntu-themes/fix-gtk322-warnings
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Robert Ancell Approve
Review via email: mp+309652@code.launchpad.net

Commit message

Fix some deprecation warnings with GTK+ 3.22

Description of the change

To test, switch your theme to something else then back, then run an app from the command line:

gsettings set org.gnome.desktop.interface gtk-theme Radiance
gsettings set org.gnome.desktop.interface gtk-theme Ambiance

These are the warnings I got before this commit:

Gtk-WARNING **: Theme parsing error: gtk-widgets.css:23:18: not a number
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:23:18: Expected a string.
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:832:10: not a number
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:832:24: Using Pango syntax for the font: style property is deprecated; please use CSS syntax
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:1985:14: not a number
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:1985:14: Expected a string.
Gtk-WARNING **: Theme parsing error: nautilus.css:55:71: Using one color stop with linear-gradient() is deprecated.
Gtk-WARNING **: Theme parsing error: nautilus.css:56:71: Using one color stop with linear-gradient() is deprecated.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

I saw the same warnings and came to the same conclusion..

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Ambiance/gtk-3.20/apps/nautilus.css'
--- Ambiance/gtk-3.20/apps/nautilus.css 2016-08-29 11:53:39 +0000
+++ Ambiance/gtk-3.20/apps/nautilus.css 2016-10-31 04:21:50 +0000
@@ -47,13 +47,13 @@
4747
48/* Toolbar */48/* Toolbar */
4949
50/* Here we use the .button background-image colors from Adwaita, but ligthen them,50/* Here we use the .button background-image colors from Adwaita, but lighten them,
51 * since is not possible to use lighten () in common css. */51 * since is not possible to use lighten () in common css. */
52@keyframes needs_attention_keyframes {52@keyframes needs_attention_keyframes {
53 0% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }53 0% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }
54 /* can't do animation-direction, so holding the color on two keyframes */54 /* can't do animation-direction, so holding the color on two keyframes */
55 30% {background-image: linear-gradient(to bottom, @theme_base_color); border-color: @theme_fg_color; } 55 30% {background-image: linear-gradient(to bottom, @theme_base_color, @theme_base_color); border-color: @theme_fg_color; }
56 90% {background-image: linear-gradient(to bottom, @theme_base_color); border-color: @theme_fg_color; }56 90% {background-image: linear-gradient(to bottom, @theme_base_color, @theme_base_color); border-color: @theme_fg_color; }
57 100% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }57 100% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }
58}58}
59.nautilus-operations-button-needs-attention {59.nautilus-operations-button-needs-attention {
6060
=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
--- Ambiance/gtk-3.20/gtk-widgets.css 2016-10-14 08:20:56 +0000
+++ Ambiance/gtk-3.20/gtk-widgets.css 2016-10-31 04:21:50 +0000
@@ -20,7 +20,7 @@
2020
21assistant .sidebar .highlight {21assistant .sidebar .highlight {
22 color: @fg_color;22 color: @fg_color;
23 font: bold;23 font-weight: bold;
24}24}
2525
26assistant .sidebar {26assistant .sidebar {
@@ -829,7 +829,8 @@
829}829}
830830
831.context-menu {831.context-menu {
832 font: regular medium;832 font-size: medium;
833 font-weight: normal;
833}834}
834835
835/***********836/***********
@@ -1982,7 +1983,7 @@
1982}1983}
19831984
1984.titlebar .title {1985.titlebar .title {
1985 font: bold;1986 font-weight: bold;
1986}1987}
19871988
1988.titlebar .subtitle {1989.titlebar .subtitle {
19891990
=== modified file 'Radiance/gtk-3.20/apps/nautilus.css'
--- Radiance/gtk-3.20/apps/nautilus.css 2016-08-29 11:53:39 +0000
+++ Radiance/gtk-3.20/apps/nautilus.css 2016-10-31 04:21:50 +0000
@@ -52,8 +52,8 @@
52@keyframes needs_attention_keyframes {52@keyframes needs_attention_keyframes {
53 0% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }53 0% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }
54 /* can't do animation-direction, so holding the color on two keyframes */54 /* can't do animation-direction, so holding the color on two keyframes */
55 30% {background-image: linear-gradient(to bottom, @theme_base_color); border-color: @theme_fg_color; } 55 30% {background-image: linear-gradient(to bottom, @theme_base_color, @theme_base_color); border-color: @theme_fg_color; }
56 90% {background-image: linear-gradient(to bottom, @theme_base_color); border-color: @theme_fg_color; }56 90% {background-image: linear-gradient(to bottom, @theme_base_color, @theme_base_color); border-color: @theme_fg_color; }
57 100% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }57 100% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }
58}58}
59.nautilus-operations-button-needs-attention {59.nautilus-operations-button-needs-attention {
6060
=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
--- Radiance/gtk-3.20/gtk-widgets.css 2016-10-14 08:20:56 +0000
+++ Radiance/gtk-3.20/gtk-widgets.css 2016-10-31 04:21:50 +0000
@@ -20,7 +20,7 @@
2020
21assistant .sidebar .highlight {21assistant .sidebar .highlight {
22 color: @fg_color;22 color: @fg_color;
23 font: bold;23 font-weight: bold;
24}24}
2525
26assistant .sidebar {26assistant .sidebar {
@@ -838,7 +838,8 @@
838}838}
839839
840.context-menu {840.context-menu {
841 font: regular medium;841 font-size: medium;
842 font-weight: normal;
842}843}
843844
844/***********845/***********
@@ -1978,7 +1979,7 @@
1978}1979}
19791980
1980.titlebar .title {1981.titlebar .title {
1981 font: bold;1982 font-weight: bold;
1982}1983}
19831984
1984.titlebar .subtitle {1985.titlebar .subtitle {

Subscribers

People subscribed via source and target branches