Ubuntu theme

Merge lp:~jbicha/ubuntu-themes/fix-gtk322-warnings into lp:ubuntu-themes

  1. fix-gtk322-warnings
  2. Merge into trunk
Proposed by Jeremy Bicha on 2016-10-31
Status: Merged
Approved by: Marco Trevisan (Treviño) on 2016-11-09
Approved revision: 521
Merged at revision: 521
Proposed branch: lp:~jbicha/ubuntu-themes/fix-gtk322-warnings
Merge into: lp:ubuntu-themes
Diff against target: 99 lines (+13/-11)
4 files modified
Ambiance/gtk-3.20/apps/nautilus.css (+3/-3)
Ambiance/gtk-3.20/gtk-widgets.css (+4/-3)
Radiance/gtk-3.20/apps/nautilus.css (+2/-2)
Radiance/gtk-3.20/gtk-widgets.css (+4/-3)
To merge this branch: bzr merge lp:~jbicha/ubuntu-themes/fix-gtk322-warnings
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve on 2016-11-09
Robert Ancell 2016-10-31 Approve on 2016-11-09
Review via email: mp+309652@code.launchpad.net

Commit Message

Fix some deprecation warnings with GTK+ 3.22

Description of the Change

To test, switch your theme to something else then back, then run an app from the command line:

gsettings set org.gnome.desktop.interface gtk-theme Radiance
gsettings set org.gnome.desktop.interface gtk-theme Ambiance

These are the warnings I got before this commit:

Gtk-WARNING **: Theme parsing error: gtk-widgets.css:23:18: not a number
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:23:18: Expected a string.
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:832:10: not a number
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:832:24: Using Pango syntax for the font: style property is deprecated; please use CSS syntax
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:1985:14: not a number
Gtk-WARNING **: Theme parsing error: gtk-widgets.css:1985:14: Expected a string.
Gtk-WARNING **: Theme parsing error: nautilus.css:55:71: Using one color stop with linear-gradient() is deprecated.
Gtk-WARNING **: Theme parsing error: nautilus.css:56:71: Using one color stop with linear-gradient() is deprecated.

To post a comment you must log in.
Robert Ancell (robert-ancell) wrote :

I saw the same warnings and came to the same conclusion..

review: Approve
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-3.20/apps/nautilus.css'
2--- Ambiance/gtk-3.20/apps/nautilus.css 2016-08-29 11:53:39 +0000
3+++ Ambiance/gtk-3.20/apps/nautilus.css 2016-10-31 04:21:50 +0000
4@@ -47,13 +47,13 @@
5
6 /* Toolbar */
7
8-/* Here we use the .button background-image colors from Adwaita, but ligthen them,
9+/* Here we use the .button background-image colors from Adwaita, but lighten them,
10 * since is not possible to use lighten () in common css. */
11 @keyframes needs_attention_keyframes {
12 0% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }
13 /* can't do animation-direction, so holding the color on two keyframes */
14- 30% {background-image: linear-gradient(to bottom, @theme_base_color); border-color: @theme_fg_color; }
15- 90% {background-image: linear-gradient(to bottom, @theme_base_color); border-color: @theme_fg_color; }
16+ 30% {background-image: linear-gradient(to bottom, @theme_base_color, @theme_base_color); border-color: @theme_fg_color; }
17+ 90% {background-image: linear-gradient(to bottom, @theme_base_color, @theme_base_color); border-color: @theme_fg_color; }
18 100% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }
19 }
20 .nautilus-operations-button-needs-attention {
21
22=== modified file 'Ambiance/gtk-3.20/gtk-widgets.css'
23--- Ambiance/gtk-3.20/gtk-widgets.css 2016-10-14 08:20:56 +0000
24+++ Ambiance/gtk-3.20/gtk-widgets.css 2016-10-31 04:21:50 +0000
25@@ -20,7 +20,7 @@
26
27 assistant .sidebar .highlight {
28 color: @fg_color;
29- font: bold;
30+ font-weight: bold;
31 }
32
33 assistant .sidebar {
34@@ -829,7 +829,8 @@
35 }
36
37 .context-menu {
38- font: regular medium;
39+ font-size: medium;
40+ font-weight: normal;
41 }
42
43 /***********
44@@ -1982,7 +1983,7 @@
45 }
46
47 .titlebar .title {
48- font: bold;
49+ font-weight: bold;
50 }
51
52 .titlebar .subtitle {
53
54=== modified file 'Radiance/gtk-3.20/apps/nautilus.css'
55--- Radiance/gtk-3.20/apps/nautilus.css 2016-08-29 11:53:39 +0000
56+++ Radiance/gtk-3.20/apps/nautilus.css 2016-10-31 04:21:50 +0000
57@@ -52,8 +52,8 @@
58 @keyframes needs_attention_keyframes {
59 0% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }
60 /* can't do animation-direction, so holding the color on two keyframes */
61- 30% {background-image: linear-gradient(to bottom, @theme_base_color); border-color: @theme_fg_color; }
62- 90% {background-image: linear-gradient(to bottom, @theme_base_color); border-color: @theme_fg_color; }
63+ 30% {background-image: linear-gradient(to bottom, @theme_base_color, @theme_base_color); border-color: @theme_fg_color; }
64+ 90% {background-image: linear-gradient(to bottom, @theme_base_color, @theme_base_color); border-color: @theme_fg_color; }
65 100% {background-image: linear-gradient(to bottom, #fafafa, #ededed 40%, #e0e0e0); border-color: @borders; }
66 }
67 .nautilus-operations-button-needs-attention {
68
69=== modified file 'Radiance/gtk-3.20/gtk-widgets.css'
70--- Radiance/gtk-3.20/gtk-widgets.css 2016-10-14 08:20:56 +0000
71+++ Radiance/gtk-3.20/gtk-widgets.css 2016-10-31 04:21:50 +0000
72@@ -20,7 +20,7 @@
73
74 assistant .sidebar .highlight {
75 color: @fg_color;
76- font: bold;
77+ font-weight: bold;
78 }
79
80 assistant .sidebar {
81@@ -838,7 +838,8 @@
82 }
83
84 .context-menu {
85- font: regular medium;
86+ font-size: medium;
87+ font-weight: normal;
88 }
89
90 /***********
91@@ -1978,7 +1979,7 @@
92 }
93
94 .titlebar .title {
95- font: bold;
96+ font-weight: bold;
97 }
98
99 .titlebar .subtitle {

Subscribers

People subscribed via source and target branches