Merge lp:~jbicha/indicator-keyboard/fix-dependencies into lp:indicator-keyboard

Proposed by Jeremy Bícha
Status: Merged
Approved by: William Hua
Approved revision: 84
Merged at revision: 90
Proposed branch: lp:~jbicha/indicator-keyboard/fix-dependencies
Merge into: lp:indicator-keyboard
Diff against target: 36 lines (+11/-3)
2 files modified
debian/changelog (+10/-2)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~jbicha/indicator-keyboard/fix-dependencies
Reviewer Review Type Date Requested Status
William Hua (community) Approve
Review via email: mp+174900@code.launchpad.net

Description of the change

Since I released 18 to the ~desktop ppa, I went ahead and bumped the version number to 19.

Without the dbus dependency, the tests fail with:

/indicator-keyboard/activate-input-source: **
GLib-GIO:ERROR:/build/buildd/glib2.0-2.37.3/./gio/gtestdbus.c:617:start_daemon: assertion failed (error == NULL): Failed to execute child process "dbus-daemon" (No such file or directory) (g-exec-error-quark, 8)

To post a comment you must log in.
Revision history for this message
William Hua (attente) wrote :

Thanks, looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-07-02 13:10:50 +0000
+++ debian/changelog 2013-07-16 01:34:29 +0000
@@ -1,9 +1,17 @@
1indicator-keyboard (0.0.0-0ubuntu18) UNRELEASED; urgency=low1indicator-keyboard (0.0.0-0ubuntu19) saucy; urgency=low
2
3 * debian/control:
4 - Don't build-depend on vala-0.20-vapi
5 - Build-depend on dbus for tests
6
7 -- Jeremy Bicha <jbicha@ubuntu.com> Mon, 15 Jul 2013 21:00:06 -0400
8
9indicator-keyboard (0.0.0-0ubuntu18) saucy; urgency=low
210
3 * Add indicator schema.11 * Add indicator schema.
4 * Repair test fixtures.12 * Repair test fixtures.
513
6 -- William Hua <william.hua@canonical.com> Mon, 01 Jul 2013 10:21:40 -040014 -- William Hua <william.hua@canonical.com> Mon, 15 Jul 2013 20:37:40 -0400
715
8indicator-keyboard (0.0.0-0ubuntu17) saucy; urgency=low16indicator-keyboard (0.0.0-0ubuntu17) saucy; urgency=low
917
1018
=== modified file 'debian/control'
--- debian/control 2013-06-24 21:16:17 +0000
+++ debian/control 2013-07-16 01:34:29 +0000
@@ -8,7 +8,7 @@
8 dh-translations,8 dh-translations,
9 libgirepository1.0-dev,9 libgirepository1.0-dev,
10 valac,10 valac,
11 valac-0.20-vapi,11 dbus-test-runner,
12 libgee-dev,12 libgee-dev,
13 libgtk-3-dev,13 libgtk-3-dev,
14 libgnome-desktop-3-dev,14 libgnome-desktop-3-dev,

Subscribers

People subscribed via source and target branches

to all changes: