Merge lp:~jbicha/activity-log-manager/fix-few-warnings into lp:activity-log-manager

Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 74
Proposed branch: lp:~jbicha/activity-log-manager/fix-few-warnings
Merge into: lp:activity-log-manager
Diff against target: 145 lines (+14/-14)
6 files modified
src/Makefile.am (+4/-4)
src/searchresults-widget.vala (+0/-1)
src/security-widget.vala (+5/-5)
src/unified-privacy-applications.vala (+0/-1)
src/unified-privacy-history.vala (+0/-1)
src/unified-privacy.vala (+5/-2)
To merge this branch: bzr merge lp:~jbicha/activity-log-manager/fix-few-warnings
Reviewer Review Type Date Requested Status
Manish Sinha (मनीष सिन्हा) Approve
Review via email: mp+173626@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2013-07-08 01:37:43 +0000
+++ src/Makefile.am 2013-07-09 01:36:26 +0000
@@ -1,4 +1,4 @@
1VALAFLAGS = \1AM_VALAFLAGS = \
2 --pkg zeitgeist-2.0 \2 --pkg zeitgeist-2.0 \
3 --pkg glib-2.0 \3 --pkg glib-2.0 \
4 --pkg gtk+-3.0 \4 --pkg gtk+-3.0 \
@@ -56,7 +56,7 @@
56if HAVE_SWITCHBOARD56if HAVE_SWITCHBOARD
57switchboarddir = $(prefix)/lib/plugs/zeitgeist/alm57switchboarddir = $(prefix)/lib/plugs/zeitgeist/alm
58switchboard_PROGRAMS = alm-switchboard58switchboard_PROGRAMS = alm-switchboard
59VALAFLAGS += -D SWITCHBOARD \59AM_VALAFLAGS += -D SWITCHBOARD \
60 --pkg pantheon60 --pkg pantheon
61alm_switchboard_LDADD = \61alm_switchboard_LDADD = \
62 $(SHARED_LIBS) \62 $(SHARED_LIBS) \
@@ -71,7 +71,7 @@
71endif71endif
7272
73if HAVE_DIAG73if HAVE_DIAG
74VALAFLAGS += \74AM_VALAFLAGS += \
75 -D DIAGNOSTIC75 -D DIAGNOSTIC
76gnomeccuidir = $(datadir)/gnome-control-center/ui/76gnomeccuidir = $(datadir)/gnome-control-center/ui/
77SUBDIRS = diagnostics77SUBDIRS = diagnostics
@@ -79,7 +79,7 @@
7979
8080
81if HAVE_CCPANEL81if HAVE_CCPANEL
82ccpaneldir = $(prefix)/lib/control-center-1/panels82ccpaneldir = $(libdir)/control-center-1/panels
83ccpanel_LTLIBRARIES = libactivity-log-manager.la83ccpanel_LTLIBRARIES = libactivity-log-manager.la
84endif84endif
8585
8686
=== modified file 'src/searchresults-widget.vala'
--- src/searchresults-widget.vala 2013-07-08 01:37:43 +0000
+++ src/searchresults-widget.vala 2013-07-09 01:36:26 +0000
@@ -19,7 +19,6 @@
19 */19 */
2020
21using Gtk;21using Gtk;
22using Gee;
2322
24namespace Alm {23namespace Alm {
2524
2625
=== modified file 'src/security-widget.vala'
--- src/security-widget.vala 2013-07-07 19:51:19 +0000
+++ src/security-widget.vala 2013-07-09 01:36:26 +0000
@@ -18,7 +18,6 @@
18 */18 */
1919
20using Gtk;20using Gtk;
21using Gee;
2221
23namespace Alm {22namespace Alm {
2423
@@ -40,8 +39,8 @@
4039
41 private void set_up_ui () {40 private void set_up_ui () {
4241
43 Gtk.ListStore liststore_delay = new Gtk.ListStore (2, typeof (string), typeof (int));42 var liststore_delay = new ListStore (2, typeof (string), typeof (int));
44 Gtk.TreeIter iter;43 TreeIter iter;
45 liststore_delay.append (out iter);44 liststore_delay.append (out iter);
46 liststore_delay.set (iter, 0, "1 second", 1, 0);45 liststore_delay.set (iter, 0, "1 second", 1, 0);
47 liststore_delay.append (out iter);46 liststore_delay.append (out iter);
@@ -68,6 +67,7 @@
68 grid.set_margin_left(25);67 grid.set_margin_left(25);
69 grid.set_column_spacing(25);68 grid.set_column_spacing(25);
70 grid.set_row_spacing(5);69 grid.set_row_spacing(5);
70 grid.set_row_homogeneous(true);
71 this.add(grid);71 this.add(grid);
7272
73 var list_focus = new GLib.List<Widget> ();73 var list_focus = new GLib.List<Widget> ();
@@ -113,7 +113,7 @@
113 try {113 try {
114 Process.spawn_command_line_async ("gnome-control-center user-accounts");114 Process.spawn_command_line_async ("gnome-control-center user-accounts");
115 } catch (SpawnError e) {115 } catch (SpawnError e) {
116 stdout.printf ("Error: %s\n", e.message);116 warning ("%s", e.message);
117 }117 }
118 return true;118 return true;
119 });119 });
@@ -126,7 +126,7 @@
126 try {126 try {
127 Process.spawn_command_line_async ("gnome-control-center power");127 Process.spawn_command_line_async ("gnome-control-center power");
128 } catch (SpawnError e) {128 } catch (SpawnError e) {
129 stdout.printf ("Error: %s\n", e.message);129 warning ("%s", e.message);
130 }130 }
131 return true;131 return true;
132 });132 });
133133
=== modified file 'src/unified-privacy-applications.vala'
--- src/unified-privacy-applications.vala 2013-07-03 08:09:42 +0000
+++ src/unified-privacy-applications.vala 2013-07-09 01:36:26 +0000
@@ -23,7 +23,6 @@
23 23
24using Gtk;24using Gtk;
25using Gee;25using Gee;
26using GLib;
27using Zeitgeist;26using Zeitgeist;
2827
29namespace Alm {28namespace Alm {
3029
=== modified file 'src/unified-privacy-history.vala'
--- src/unified-privacy-history.vala 2013-02-15 23:09:09 +0000
+++ src/unified-privacy-history.vala 2013-07-09 01:36:26 +0000
@@ -21,7 +21,6 @@
21 */21 */
2222
23using Gtk;23using Gtk;
24using Gee;
25using Zeitgeist;24using Zeitgeist;
2625
27namespace Alm {26namespace Alm {
2827
=== modified file 'src/unified-privacy.vala'
--- src/unified-privacy.vala 2013-07-08 02:42:55 +0000
+++ src/unified-privacy.vala 2013-07-09 01:36:26 +0000
@@ -19,7 +19,6 @@
19 19
20using Gtk;20using Gtk;
21using Gee;21using Gee;
22using GLib;
23using Zeitgeist;22using Zeitgeist;
2423
25namespace Alm {24namespace Alm {
@@ -854,7 +853,11 @@
854 else if (index == 4){853 else if (index == 4){
855 tr = new Zeitgeist.TimeRange.anytime();854 tr = new Zeitgeist.TimeRange.anytime();
856 get_history.begin (tr);855 get_history.begin (tr);
857 recent.purge_items();856 try {
857 recent.purge_items();
858 } catch (Error err) {
859 warning ("%s", err.message);
860 }
858 }861 }
859 }862 }
860 863

Subscribers

People subscribed via source and target branches