Code review comment for lp:~jbaudoux/anybox.recipe.openerp/20130908_relative_paths

Revision history for this message
Georges Racinet (gracinet) wrote :

Took a look at the merge today (sorry, I'm late) and a few more question arise:

 - the invocation of Session in the generated interpreter now uses the buildout dir (to read the expected VERSION file)
 - is there a specific reason not to pass a relative path in the scripts generation, too ?

That makes too much questionning for merging before 1.8.0, I'll take a look at these again rigth after the release of 1.8.0 (should be first thing tomorrow morning CEST).

« Back to merge proposal