Code review comment for lp:~jbaudoux/anybox.recipe.openerp/20130908_relative_paths

Revision history for this message
Georges Racinet (gracinet) wrote :

Really interesting if I understand it correctly, this the forever delayed "TODO investigate these options" ! Thank you for the contribution.

I'd need to read the details of _relativitize(), and especially understand why the one from zc.buildout.easy_install is not enough, but one thing is for sure : this will need dedicated unit tests and documentation : if OpenERP buildouts can be made relocatable, then the doc must state it explicitely, along with limitations (simply pointing out that it behaves exactly as zc.recipe.egg in that respect, it that is the case).

Not yet decided whether this can go to 1.7 or trunk. There's nothing that seems to be so dangerous (a breakage would not stay unnoticed for long).

« Back to merge proposal