Code review comment for lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

Sorry I miss something :

Line 24 and 55, if employee has no department_id define, the code will break.

Can you please add a test on department_id.

Regards,

review: Needs Fixing (code review, no tests)

« Back to merge proposal