Merge lp:~jaywink/ubuntu-accomplishments-daemon/daemon-fix-1011903 into lp:ubuntu-accomplishments-daemon

Proposed by Jason Robinson
Status: Merged
Merge reported by: Jono Bacon
Merged at revision: not available
Proposed branch: lp:~jaywink/ubuntu-accomplishments-daemon/daemon-fix-1011903
Merge into: lp:ubuntu-accomplishments-daemon
Diff against target: 24 lines (+14/-0)
1 file modified
accomplishments/daemon/api.py (+14/-0)
To merge this branch: bzr merge lp:~jaywink/ubuntu-accomplishments-daemon/daemon-fix-1011903
Reviewer Review Type Date Requested Status
Jono Bacon Approve
Review via email: mp+117774@code.launchpad.net

Description of the change

Fixed by adding a restart to the Ubuntu One SyncDaemonTool to reload its config. Change reflects to U1 client control panel.

Hopefully this resolves the issue and enhances user experience.

Ps. The bug was about the viewer but the code change really suited the daemon better.

To post a comment you must log in.
Revision history for this message
Jono Bacon (jonobacon) wrote :

Wonderful contribution, Jason!

This looks and works great. Thanks for contributing, and we look forward to seeing more contributions from you! :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'accomplishments/daemon/api.py'
--- accomplishments/daemon/api.py 2012-07-31 18:00:04 +0000
+++ accomplishments/daemon/api.py 2012-08-01 20:03:18 +0000
@@ -1674,6 +1674,20 @@
16741674
1675 with open(cfile, 'wb') as configfile:1675 with open(cfile, 'wb') as configfile:
1676 config.write(configfile)1676 config.write(configfile)
1677
1678 # restart SyncDaemonTool to use new settings immediately, fixes LP#1011903
1679 self.ubuntuone_restart_syncdaemontool()
1680
1681 def ubuntuone_restart_syncdaemontool(self):
1682 if self.sd:
1683 log.msg("Stopping syncdaemontool")
1684 d = self.sd.quit()
1685 d.addCallback(self.ubuntuone_start_syncdaemontool)
1686
1687 def ubuntuone_start_syncdaemontool(self, value):
1688 if self.sd:
1689 log.msg("Starting syncdaemontool")
1690 self.sd.start()
16771691
1678 def get_block_ubuntuone_notification_bubbles(self):1692 def get_block_ubuntuone_notification_bubbles(self):
1679 u1configdir = os.path.join(1693 u1configdir = os.path.join(

Subscribers

People subscribed via source and target branches