> Looks good! Just one thing... the disables at the top of the file. I would
> rather see them localized for a specific line (ie, one method name that can't
> change due to base names or something), or a global pylintrc rule. Can you
> give more info on the two disable msgs at the top?
Sure. :)
The C0103 is for non-conventional variable names. python's (and twisted's Trials) unittest module uses methods names that don't jive with our standards. Namely, they use camelCasing instead of underscore_lowered names because of its genesis from JUnit.
The W0511 is generated every time a TODO(xxx) is placed in code comments. We have these all over the place, and I suggest putting it in the global pylintrc file.
> Looks good! Just one thing... the disables at the top of the file. I would
> rather see them localized for a specific line (ie, one method name that can't
> change due to base names or something), or a global pylintrc rule. Can you
> give more info on the two disable msgs at the top?
Sure. :)
The C0103 is for non-conventional variable names. python's (and twisted's Trials) unittest module uses methods names that don't jive with our standards. Namely, they use camelCasing instead of underscore_lowered names because of its genesis from JUnit.
The W0511 is generated every time a TODO(xxx) is placed in code comments. We have these all over the place, and I suggest putting it in the global pylintrc file.
Thoughts?
-jay