I'm marking Approved b/c what follows are nits that shouldn't necessarily hold up patch. I'll leave to your discretion whether they should be fixed with this merge:
* options_to_conf is no longer used, so we can strike that as well
* the defaults regex code is no longer used (outside of tests) so we can strike that as well
I think with both of those removed, common.config will be pretty clean.
Great cleanups Jay, thanks!
I'm marking Approved b/c what follows are nits that shouldn't necessarily hold up patch. I'll leave to your discretion whether they should be fixed with this merge:
* options_to_conf is no longer used, so we can strike that as well
* the defaults regex code is no longer used (outside of tests) so we can strike that as well
I think with both of those removed, common.config will be pretty clean.