Code review comment for lp:~jaypipes/glance/parallax-register-image

Revision history for this message
Jay Pipes (jaypipes) wrote :

> Why does ImageController.__init__ exist?

lol. :) Leftover from when I had some debugging statements in there. ::blush::

> 57: should be
> if 'status' not in image_data:
> or possibly 56/57/58 could be replaced with
> image_data.setdefault('status', 'available')

Ah, nice. Thanks.

> 101: i assume you meant to remove support for GET /images/detail.

Yes, that does not comply with the Atom publishing protocol. No need for it AFAICT.

> Otherwise, lgtm.

Thanks! I'll push those little fixes later today :)

« Back to merge proposal