Code review comment for lp:~jaypipes/glance/docs

Revision history for this message
Jay Pipes (jaypipes) wrote :

Hi Anne, thanks for the review!

> Just a couple of comments, other than "I love it!" Nicely done.
>
> I'd remove "glance.openstack.org" in the examples of a vm store. Maybe use
> vmstore.openstack.org but avoid the use of glance.openstack.org since it's a
> clickable url that takes them to the doc site which is potentially confusion
> for the examples you're using.

Done. s/glance.openstack.org/glance.example.com/g

> Couple of nitpicks - ensure it's means "it is" and use periods at the end of
> bulleted list items.

Done.

> If you want the CSS to match, you could use the Swift site as an example where
> the tweaks.css adds in OpenStack colors. Swift doesn't have the @OpenStack
> Twitter feed on the front page, Nova does. Feel free to copy the site you like
> best.

Done. Added both :)

> Should we track Glance.openstack.org with its own Google Analytics code? I can
> give the code to you if you want, or I can embed it after this gets merged.

Please feel free to do what you think is best here and to do that in a separate merge.

Thanks!
jay

« Back to merge proposal