Code review comment for lp:~jaypipes/glance/bug819336

Revision history for this message
Jay Pipes (jaypipes) wrote :

I think I know what's going on. glance-scrubber was recently added to
the list of servers always started in the functional tests, but:

a) It wasn't added to the ping() routine, and so ping() returns true
even when the scrubber may not have started, therefore the scrubber
may be called before it is actually attached to a socket...
b) The scrubber ONLY needs to be started when daemon=True is passed in
start_servers()

I'll make a commit with the above changes and see if that fixes things.
-jay

On Mon, Aug 1, 2011 at 1:37 PM, Brian Waldon <email address hidden> wrote:
> Woah, let this tab sit open too long. Take it away, Jay...
> --
> https://code.launchpad.net/~jaypipes/glance/bug819336/+merge/70037
> You are the owner of lp:~jaypipes/glance/bug819336.
>

« Back to merge proposal