Code review comment for lp:~jaypipes/glance/bug759018

Revision history for this message
Rick Harris (rconradharris) wrote :

> 47 + raise HTTPConflict(msg, request=req)
> 52 + raise HTTPBadRequest(msg, request=req)

Looks like `msg` needs interpolation. Perhaps:

    msg = ("Attempt to upload duplicate image: %s" % str(e))

> 15 + logger.debug(msg)
> 33 + logger.debug(msg)

Might be better to log this at the error level so it's more in our face.

Otherwise, looks good and tests pass.

review: Needs Fixing

« Back to merge proposal