Code review comment for lp:~jaypipes/glance/bug713154

Revision history for this message
Christopher MacGown (0x44) wrote :

Hi Jay,

The functional tests work, but the S3 unit test is failing:

======================================================================
ERROR: test_add (tests.unit.test_s3_store.TestS3Backend)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/chris/Projects/review_day/bug713154/tests/unit/test_s3_store.py", line 244, in test_add
    for chunk in new_image_s3:
  File "/Users/chris/Projects/review_day/bug713154/glance/store/s3.py", line 53, in __iter__
    self.close()
  File "/Users/chris/Projects/review_day/bug713154/glance/store/s3.py", line 58, in close
    self.fp.close()
AttributeError: FakeKey instance has no attribute 'close'

======================================================================
ERROR: test_get (tests.unit.test_s3_store.TestS3Backend)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/chris/Projects/review_day/bug713154/tests/unit/test_s3_store.py", line 188, in test_get
    for chunk in image_s3:
  File "/Users/chris/Projects/review_day/bug713154/glance/store/s3.py", line 53, in __iter__
    self.close()
  File "/Users/chris/Projects/review_day/bug713154/glance/store/s3.py", line 58, in close
    self.fp.close()
AttributeError: FakeKey instance has no attribute 'close'

review: Needs Fixing

« Back to merge proposal