Code review comment for lp:~jaypipes/glance/bug704854

No it's not.

On Wed, Feb 23, 2011 at 3:58 PM, Vish Ishaya <email address hidden> wrote:
> argparse isn't in python 2.6, no?
> On Feb 23, 2011, at 12:48 PM, OpenStack Hudson wrote:
>
>> The attempt to merge lp:~jaypipes/glance/bug704854 into lp:glance failed. Below is the output from the failed tests.
>>
>> running test
>> running egg_info
>> creating glance.egg-info
>> writing glance.egg-info/PKG-INFO
>> writing top-level names to glance.egg-info/top_level.txt
>> writing dependency_links to glance.egg-info/dependency_links.txt
>> writing manifest file 'glance.egg-info/SOURCES.txt'
>> reading manifest file 'glance.egg-info/SOURCES.txt'
>> reading manifest template 'MANIFEST.in'
>> warning: no files found matching 'LICENSE'
>> warning: no files found matching 'ChangeLog'
>> warning: no files found matching 'tests/test_data.py'
>> writing manifest file 'glance.egg-info/SOURCES.txt'
>> running build_ext
>>
>> Tests raises BadRequest for invalid store header ... ok
>> Tests raises BadRequest for invalid store header ... ok
>> Tests creates a queued image for no body and no loc header ... ok
>> test_delete_image (tests.unit.test_api.TestGlanceAPI) ... ok
>> test_delete_non_exists_image (tests.unit.test_api.TestGlanceAPI) ... ok
>> Test for HEAD /images/<ID> ... ok
>> test_show_image_basic (tests.unit.test_api.TestGlanceAPI) ... ok
>> test_show_non_exists_image (tests.unit.test_api.TestGlanceAPI) ... ok
>> Tests that the /images POST registry API creates the image ... ok
>> Tests proper exception is raised if a bad status is set ... ok
>> Tests that the /images DELETE registry API deletes the image ... ok
>> Tests proper exception is raised if attempt to delete non-existing ... ok
>> Tests that the /images/detail registry API returns ... ok
>> Tests that the /images registry API returns list of ... ok
>> Tests that the root registry API returns "index", ... ok
>> Tests that the /images PUT registry API updates the image ... ok
>> Tests proper exception is raised if attempt to update non-existing ... ok
>> Test ClientConnectionError raised ... ok
>> Tests proper exception is raised if image with ID already exists ... ok
>> Tests that we can add image metadata and returns the new id ... ok
>> Tests a bad status is set to a proper one by server ... ok
>> Tests BadRequest raised when supplying bad store name in meta ... ok
>> Tests can add image by passing image data as file ... ok
>> Tests can add image by passing image data as string ... ok
>> Tests add image by passing image data as string w/ no size attr ... ok
>> Tests that we can add image metadata with properties ... ok
>> Tests client returns image as queued ... ok
>> Tests that image metadata is deleted properly ... ok
>> Tests cannot delete non-existing image ... ok
>> Test a simple file backend retrieval works as expected ... ok
>> Tests that the detailed info about public images returned ... ok
>> Test correct set of public image returned ... ok
>> Tests that the detailed info about an image returned ... ok
>> Tests that NotFound is raised when getting a non-existing image ... ok
>> Test retrieval of a non-existing image returns a 404 ... ok
>> Tests that the /images PUT registry API updates the image ... ok
>> Tests non existing image update doesn't work ... ok
>> Tests proper exception is raised if image with ID already exists ... ok
>> Tests that we can add image metadata and returns the new id ... ok
>> Tests proper exception is raised if a bad status is set ... ok
>> Tests that we can add image metadata with properties ... ok
>> Tests that image metadata is deleted properly ... ok
>> Tests cannot delete non-existing image ... ok
>> Tests that the detailed info about an image returned ... ok
>> Tests that the detailed info about public images returned ... ok
>> Test correct set of public image returned ... ok
>> Tests that NotFound is raised when getting a non-existing image ... ok
>> Tests that the /images PUT registry API updates the image ... ok
>> Tests non existing image update doesn't work ... ok
>> test_common_options (tests.unit.test_config.TestConfig) ... ok
>> test_parse_options (tests.unit.test_config.TestConfig) ... Usage: setup.py [options]
>>
>> setup.py: error: no such option: --unknown
>> ok
>> test_db_sync_downgrade_then_upgrade (tests.unit.test_migrations.TestMigrations) ... ok
>> A test for LP bug #704854 -- Exception thrown by registry ... FAIL
>> test_get (tests.unit.test_stores.TestFilesystemBackend) ... ok
>> test_http_get (tests.unit.test_stores.TestHTTPBackend) ... ok
>> test_https_get (tests.unit.test_stores.TestHTTPBackend) ... ok
>> test_get (tests.unit.test_stores.TestS3Backend) ... ok
>> test_get (tests.unit.test_stores.TestSwiftBackend) ... ok
>> test_get_bad_uri (tests.unit.test_stores.TestSwiftBackend) ... ok
>> test_url_parsing (tests.unit.test_stores.TestSwiftBackend) ... ok
>>
>> ======================================================================
>> FAIL: A test for LP bug #704854 -- Exception thrown by registry
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>>  File "/tmp/tmp1dNloO/tests/unit/test_misc.py", line 169, in test_exception_not_eaten_from_registry_to_api
>>    "result from glance-upload:\n%(e)s" % locals())
>> AssertionError: Could not find 'Invalid image type' in result from glance-upload:
>> Command ./bin/glance-upload --port=32001 --type=invalid /tmp/tmplcRFkR 'my image' did not succeed. Returned an exit code of 1.
>>
>> STDOUT:
>>
>> STDERR: Traceback (most recent call last):
>>  File "./bin/glance-upload", line 39, in <module>
>>    import argparse
>> ImportError: No module named argparse
>>
>>
>> ----------------------------------------------------------------------
>> Ran 60 tests in 4.158s
>>
>> FAILED (failures=1)
>>
>> --
>> https://code.launchpad.net/~jaypipes/glance/bug704854/+merge/50773
>> Your team Glance Core is subscribed to branch lp:glance.
>
>
> --
> https://code.launchpad.net/~jaypipes/glance/bug704854/+merge/50773
> You are the owner of lp:~jaypipes/glance/bug704854.
>