Code review comment for lp:~jaypipes/drizzle/captain-20090915-01

Brian Aker wrote:
> Review: Needs Fixing
> A few things:
> 742 + res= (error >= 0 || session->is_error());
> 743 + DRIZZLE_DELETE_DONE(res, deleted);
>
> On non-dtrace systems this causes an evaluation/assign that will never be used (combine the statement) (once in the code res was the right thing to do, once it was not).
>
> DRIZZLE_QUERY_EXEC_START() <-- why is the third param not const?

Hmmm...agreed. Nice catch. Padraig, can you try using a
const_cast<const char *>(session->db) for both DRIZZLE_QUERY_START() and
DRIZZLE_QUERY_EXEC_START() calls? Thanks!

> Awesome fixes on all of the conversion work.
>
> I can just fix this stuff BTW (working with someone right now on code reviews).

I'd prefer if Padraig pushed a fix to his branch and we merge in from there.

Thanks!

Jay