Code review comment for lp:~jaypipes/drizzle/captain-20090915-01

Revision history for this message
Brian Aker (brianaker) wrote :

A few things:
742 + res= (error >= 0 || session->is_error());
743 + DRIZZLE_DELETE_DONE(res, deleted);

On non-dtrace systems this causes an evaluation/assign that will never be used (combine the statement) (once in the code res was the right thing to do, once it was not).

DRIZZLE_QUERY_EXEC_START() <-- why is the third param not const?

Awesome fixes on all of the conversion work.

I can just fix this stuff BTW (working with someone right now on code reviews).

review: Needs Fixing

« Back to merge proposal