A few things:
742 + res= (error >= 0 || session->is_error());
743 + DRIZZLE_DELETE_DONE(res, deleted);
On non-dtrace systems this causes an evaluation/assign that will never be used (combine the statement) (once in the code res was the right thing to do, once it was not).
DRIZZLE_QUERY_EXEC_START() <-- why is the third param not const?
Awesome fixes on all of the conversion work.
I can just fix this stuff BTW (working with someone right now on code reviews).
A few things: >is_error( )); DELETE_ DONE(res, deleted);
742 + res= (error >= 0 || session-
743 + DRIZZLE_
On non-dtrace systems this causes an evaluation/assign that will never be used (combine the statement) (once in the code res was the right thing to do, once it was not).
DRIZZLE_ QUERY_EXEC_ START() <-- why is the third param not const?
Awesome fixes on all of the conversion work.
I can just fix this stuff BTW (working with someone right now on code reviews).