Code review comment for lp:~javierder/bzr-eclipse/send_command

On Mon, Apr 20, 2009 at 4:00 PM, Javier Derderian <email address hidden> wrote:
> Ok,
> Based on your input I fixed the issues you mentioned.
>

Great!

> About the cancel, I just changed the variable to allow cancel, is that enough or I have to do something else?
>

regarding how to fire some work/command as a Job take a look to the
PushAction class (or do a search for Job class in bzr-eclipse) ;)

> About the browse button, I'll add it to my list of things for the next month, because I'm still trying to be friend with Java and Eclipse and I have no idea how to do it.
> It's first in my to-do list.

Ok, you could take a look to
/org.vcs.bazaar.eclipse.ui/src/org/vcs/bazaar/eclipse/ui/wizards/project/BranchWizardBranchLocationPage.java,
lines: 90-101
that's an example of using the org.eclipse.swt.widgets.DirectoryDialog
class bound to a button (in this case should be the
org.eclipse.swt.widgets.FileDialog class)

>
> I'll check with canonical about the Copyright headers

I just talked with Martin Pool about this, and the copyright should be
for Canonical.

>
> Thanks again!

Thanks,

Cheers,

> --
> https://code.edge.launchpad.net/~javierder/bzr-eclipse/send_command/+merge/5676
> You are reviewing the proposed merge of lp:~javierder/bzr-eclipse/send_command into lp:bzr-eclipse.
>