Code review comment for lp:~javierder/bzr-eclipse/send_command
Revision history for this message
| Guillermo Gonzalez (verterok) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi Javier,
On Sat, Apr 18, 2009 at 9:29 PM, Javier Derderian <email address hidden> wrote:
>> Copyright headers look odd, no?
>
> yes they do. They're the same in lots of original BzrEclipse files, like LocationInputDi
I think Martin is talking about the copyright in SendAction.java, as
it might be a similar copyright in other files of bzr-eclipse, it's
wrong (my fault, sorry for the confusion). Looks like that a search &
replace didn't worked as expected.
Most of the files have a placeholder for the LICENSE/COPYRIGHT, that I
should complete.
>
>
> what should be there?
I think that as Canonical is the sponsor of this work, the copyright
belongs to them, but that depends on the arrangement/
signed.
About the license, I know it's not clear. I think that using EPL it's
ok. but don't know if a specific license should be used (as part of
your contract with them).
Cheers,
> --
> https:/
> You are requested to review the proposed merge of lp:~javierder/bzr-eclipse/send_command into lp:bzr-eclipse.
>