I haven't been trying as hard as I could be. I'll try harder.
There are two spots here I'm concerned about:
326 - output = "total: %d, passes: %d, failure: %d, error: %d" % (tests_run, self.passes, self.failures, self.errors + self.fetch_errors) 327 + output = ("total: %d, passes: %d, failure: %d, error: %d" 328 + % (tests_run, self.passes, self.failures, 329 + self.errors + self.fetch_errors))
493 - return "%s: %s, %s, %s" % (self.name, self.description, self.command, self.timeout) 494 + return ("%s: %s, %s, %s" 495 + % (self.name, self.description, self.command, self.timeout))
Is this going to turn what was a string into a tuple containing a string? If you've run the client with these changes and it works, then we're fine, I just don't know the client code as well.
« Back to merge proposal
I haven't been trying as hard as I could be. I'll try harder.
There are two spots here I'm concerned about:
326 - output = "total: %d, passes: %d, failure: %d, error: %d" % (tests_run, self.passes, self.failures, self.errors + self.fetch_errors)
327 + output = ("total: %d, passes: %d, failure: %d, error: %d"
328 + % (tests_run, self.passes, self.failures,
329 + self.errors + self.fetch_errors))
493 - return "%s: %s, %s, %s" % (self.name, self.description, self.command, self.timeout)
494 + return ("%s: %s, %s, %s"
495 + % (self.name, self.description, self.command, self.timeout))
Is this going to turn what was a string into a tuple containing a string? If you've run the client with these changes and it works, then we're fine, I just don't know the client code as well.