Code review comment for lp:~javier.collado/utah/readable-preseed

Revision history for this message
Andy Doan (doanac) wrote :

On 02/20, Max Brustkern wrote:
> This looks pretty great. I think it would be awesome if we also templated the default preseed, libvirt XML file, and maybe even stuff like the kernel command line options and the commands we pass to cobbler, but all of those would involve more work to keep them compatible with user input. I think this is a really good step in the direction of separation of code from configuration.
>
> As far as the actual code, it all looks reasonable to me. If you've tested it, it should be fine. If I have some time, I'll try to test it as well.
>
> Finally, if we merge this before the rsyslog stuff, we'll need to make sure that branch gets properly updated to take these changes into account, and vice versa.

Its okay if you want to merge this first. I'm taking Max's branch and
mine and rebasing them. With the new rsylogd support I'm adding its
become sufficiently different that dragging the original history around
isn't going to be helpful.

« Back to merge proposal