Code review comment for lp:~javier.collado/utah/provisioned_machine

Revision history for this message
Javier Collado (javier.collado) wrote :

Max, thanks for the logs.

I finally realized that I wasn't seeing the preseed problem because of a
configuration option in the system you're using that isn't enabled by default.
Anyway, using --outputpreseed I got to the same result.

Regarding how to fix the problem, in my opinion we shouldn't catch exceptions
for something that can be checked upfront, but also using hasattr is not a very
good solution because it doesn't commnicate much about the design. The change
I've pushed checks if machine is a ProvisionedMachine object which I feel makes
clearer what kind of machine isn't expected to have a preseed file available.
If you disagree, then we can talk about alternative solutions.

I'm looking now at the problem regarding the log output.

« Back to merge proposal