Code review comment for lp:~javier.collado/utah/bug1101189-2

Revision history for this message
Max Brustkern (nuclearbob) wrote :

If line 21 is changing to use _cobble, you should omit the 'sudo' 'cobbler' or else you'll have that twice. I don't see any stderr from cobbler system find.

While we're doing this, would it make any sense to separate stdout and stderr the way SSHMachine.run currently does? We could also do that later, and I think updating SSHMachine to return a dict, like you did with these methods, is a good idea.

I like the rest of it. I think your method of improving these is better than what we've got in other places right now.

« Back to merge proposal