Code review comment for lp:~javier.collado/utah/bug1076437

Revision history for this message
Javier Collado (javier.collado) wrote :

@Max

Yes, there are some warnings/errors in the new version of the pep8 (tool)
that address over/under-indentation.

What PEP8 (document) says, with regard to that is:
---
Use 4 spaces per indentation level.

For really old code that you don't want to mess up, you can continue to use 8-space tabs.

Continuation lines should align wrapped elements either vertically using Python's implicit line joining inside parentheses, brackets and braces, or using a hanging indent. When using a hanging indent the following considerations should be applied; there should be no arguments on the first line and further indentation should be used to clearly distinguish itself as a continuation line.
---

To get some small examples you can use: "pep8 --show-pep8 <file>". Anyway, as usual,
my advice is to integrate that tool (or pyflakes) into your preferred editor
and get the warnings/errors as you write.

Once all those issues are continuously highlighted, they get so annoying that you end up
fixing them sooner or later.

« Back to merge proposal