Merge lp:~javier.collado/utah/bug1071020 into lp:utah

[Javier Collado]

This branch creates a fake command result when the run_as user is not found in
the password database with an error that is friendlier than the error that the
user would get if the command were really executed.

I don't like much creating fake results to convey error messages, but I haven't
found any better way to do this. Maybe we could create a different result
dictionary for those commands that haven't been executed, but I don't really
thing that is worth the effort for now. Please let me now your thoughts on this.

[Andy Doan (doanac)]

+1

[Max Brustkern (nuclearbob)]

This looks good to me. At some point, I think it would be nice if we could find a good way to support a generic 'unprivileged' user that would use the default user on the system, but maybe the real answer is that provisioning should always install the system with the same unprivileged user...

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2013-02-28 12:41:10 +0000
+++ debian/changelog	2013-03-04 14:57:21 +0000
@@ -3,6 +3,8 @@
   * Added battery_measurements boolean variable to runlist (defaults to False)
   * Added success command failure detection (LP: #1126115)
   * Added installation failure log message (LP: #1126361)
+  * Added check to make sure user is in the password database
+    (LP: #1071020)
 
  -- Javier Collado <[e-mail]>  Wed, 27 Feb 2013 09:28:58 +0100
 

=== modified file 'utah/client/common.py'
--- utah/client/common.py	2013-02-27 09:05:41 +0000
+++ utah/client/common.py	2013-03-04 14:57:21 +0000
@@ -108,6 +108,16 @@
     """
 
     if run_as is not None:
+        # check username exists in the password database
+        try:
+            pwd.getpwnam(run_as)
+        except KeyError:
+            return make_result(
+                command,
+                FAIL,
+                stderr=('{!r} user not found in the password database'
+                        .format(run_as)))
+
         # add -n so sudo will not prompt for a password on the tty
         cmd_prefix = "sudo -n -u {} ".format(run_as)
     else: