Code review comment for lp:~javier.collado/utah/bug1050976

Revision history for this message
Javier Collado (javier.collado) wrote :

@Max

I've added a new configuration variable named sshserverinstall that can have two values: 'before reboot' and 'after reboot'. Based on this configuration variable value, the command to execute in the chroot is selected, that is, when 'before reboot' is set the apt-get install is executed directly and when 'after reboot' is set, the apt-get install is added to /etc/rc.local

The variable name isn't really very good because gdebi package is installed aside from openssh-server. If you've got a better name, please let me know. By the way, I don't like the configuration variables being words together without underscores or capital letters to separate them, but I decided to be consistent with the other ones.

With regard to the timeouts, they have been already updated in config.py.

review: Needs Resubmitting

« Back to merge proposal