Code review comment for lp:~javier.collado/utah/bug1042895
Revision history for this message
| Javier Collado (javier.collado) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
@Max
Thanks for your review because those were three good catches.
1. Dependencies
I've removed them to match what we currently have in the dev branch. dpkg-dev was in the merge, but isn't in the dev branch. Do you know if we're actually using anything from there?
2. Absolute path in .install files
I've never read the official documentation, but I've always seen relative paths as you said.
3. prerm script
That's correct, the prerm script is no longer needed. Just for my own curiosity I tried to removed the package and didn't get any error. Anyway, without the script everything works exactly the same way.