Merge lp:~javier.collado/utah/bug1039555-client into lp:~utah/utah/bug1039555

Proposed by Javier Collado
Status: Merged
Approved by: Max Brustkern
Approved revision: 663
Merged at revision: 660
Proposed branch: lp:~javier.collado/utah/bug1039555-client
Merge into: lp:~utah/utah/bug1039555
Diff against target: 144 lines (+47/-8)
8 files modified
Makefile (+5/-2)
client-Makefile (+5/-2)
client.py (+1/-1)
debian/control (+1/-1)
debian/utah-client.manpages (+1/-0)
docs/source/conf.py (+1/-1)
docs/source/man/utah.rst (+32/-0)
utah_howto.txt (+1/-1)
To merge this branch: bzr merge lp:~javier.collado/utah/bug1039555-client
Reviewer Review Type Date Requested Status
Javier Collado (community) Needs Resubmitting
Review via email: mp+120768@code.launchpad.net

Description of the change

This merge contains the changes needed to generate a man page for the client.

Note that the merge is against a branch owned by the team (lp:~utah/utah/bug1039555) to handle all the changes for this bug. Hence, this branch doesn't attempt to fix the whole bug, but just a part of it which is the generation of the man page for the client.

Remaining changes:
- Set final text for the `utah` man page
- Generate man pages for the server scripts
- Set the final text for the server scripts

Every set of changes is expected to be handled in a different branch to be merged also against lp:~utah/utah/bug1039555. Once everything is in that branch, the merge against lp:utah/dev will be proposed.

To post a comment you must log in.
662. By Javier Collado

Added python-sphinx as build dependency

Otherwise packaging while fail when trying to generate man pages.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I think "Ubuntu Automation Test Harness" should be "Ubuntu Test Automation Harness" or just "UTAH." UATH is the old version.

663. By Javier Collado

Fixed typo (uath -> utah)

Revision history for this message
Javier Collado (javier.collado) wrote :

@Max

Thanks, I copied client.py output without realizing about the type. Fixed it in the man page and in a couple of other places.

review: Needs Resubmitting
Revision history for this message
Javier Collado (javier.collado) wrote :

@Max

Let me know if you find some other issue. Otherwise, I'll merge this and continue the work on the man pages.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Looks good to me. Merge away!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2012-08-14 16:42:41 +0000
+++ Makefile 2012-08-22 16:44:18 +0000
@@ -1,5 +1,5 @@
1PYC_PATTERN?=*.pyc1PYC_PATTERN?=*.pyc
2all: client conf/utah/bootspeed-preseed.cfg conf/utah/bridged-network-vm.xml conf/utah/config2all: client conf/utah/bootspeed-preseed.cfg conf/utah/bridged-network-vm.xml conf/utah/config manpages
33
4client:4client:
5 [ -d "client" ] || mkdir client5 [ -d "client" ] || mkdir client
@@ -17,6 +17,9 @@
17conf/utah/config:17conf/utah/config:
18 ./utah/config.py > conf/utah/config18 ./utah/config.py > conf/utah/config
1919
20manpages:
21 cd docs && make man
22
20clean:23clean:
21 find . -name "$(PYC_PATTERN)" -delete24 find . -name "$(PYC_PATTERN)" -delete
22 rm -rf client25 rm -rf client
@@ -26,4 +29,4 @@
26 rm -f utah_*29 rm -f utah_*
27 rm -f utah-*30 rm -f utah-*
2831
29.PHONY: client clean32.PHONY: client clean manpages
3033
=== modified file 'client-Makefile'
--- client-Makefile 2012-05-21 14:05:50 +0000
+++ client-Makefile 2012-08-22 16:44:18 +0000
@@ -1,4 +1,4 @@
1all: utah-client_fake_all.deb utah/config1all: utah-client_fake_all.deb utah/config manpages
22
3utah-client_fake_all.deb:3utah-client_fake_all.deb:
4 touch utah-client_fake_all.deb4 touch utah-client_fake_all.deb
@@ -6,7 +6,10 @@
6utah/config:6utah/config:
7 touch utah/config7 touch utah/config
88
9manpages:
10 cd docs && make man
11
9clean:12clean:
10 rm utah/config13 rm utah/config
1114
12.PHONY: clean15.PHONY: clean manpages
1316
=== modified file 'client.py'
--- client.py 2012-08-09 21:39:20 +0000
+++ client.py 2012-08-22 16:44:18 +0000
@@ -23,7 +23,7 @@
23 import argparse23 import argparse
2424
25 parser = argparse.ArgumentParser(25 parser = argparse.ArgumentParser(
26 description='Ubuntu Automation Testing Harness')26 description='Ubuntu Testing Automation Harness')
27 parser.add_argument('--resume', action='store_true',27 parser.add_argument('--resume', action='store_true',
28 help='Continue a previous run. Used after a reboot')28 help='Continue a previous run. Used after a reboot')
29 parser.add_argument('-s', '--state-file',29 parser.add_argument('-s', '--state-file',
3030
=== modified file 'debian/control'
--- debian/control 2012-08-14 16:55:16 +0000
+++ debian/control 2012-08-22 16:44:18 +0000
@@ -3,7 +3,7 @@
3X-Python-Version: >= 2.53X-Python-Version: >= 2.5
4Priority: optional4Priority: optional
5Maintainer: Max Brustkern <max@canonical.com>5Maintainer: Max Brustkern <max@canonical.com>
6Build-Depends: debhelper (>= 7.0.50~), python-all, devscripts6Build-Depends: debhelper (>= 7.0.50~), devscripts, python-all, python-sphinx
7Standards-Version: 3.9.37Standards-Version: 3.9.3
8Homepage: https://code.launchpad.net/utah8Homepage: https://code.launchpad.net/utah
9Vcs-Bzr: https://code.launchpad.net/utah9Vcs-Bzr: https://code.launchpad.net/utah
1010
=== added file 'debian/utah-client.manpages'
--- debian/utah-client.manpages 1970-01-01 00:00:00 +0000
+++ debian/utah-client.manpages 2012-08-22 16:44:18 +0000
@@ -0,0 +1,1 @@
1docs/build/man/utah.1
02
=== modified file 'docs/source/conf.py'
--- docs/source/conf.py 2012-08-20 11:33:46 +0000
+++ docs/source/conf.py 2012-08-22 16:44:18 +0000
@@ -230,7 +230,7 @@
230# One entry per manual page. List of tuples230# One entry per manual page. List of tuples
231# (source start file, name, description, authors, manual section).231# (source start file, name, description, authors, manual section).
232man_pages = [232man_pages = [
233 ('index', 'utah', u'UTAH Documentation',233 ('man/utah', 'utah', u'Ubuntu Test Automation Harness',
234 [u'Canonical Ltd'], 1)234 [u'Canonical Ltd'], 1)
235]235]
236236
237237
=== added directory 'docs/source/man'
=== added file 'docs/source/man/utah.rst'
--- docs/source/man/utah.rst 1970-01-01 00:00:00 +0000
+++ docs/source/man/utah.rst 2012-08-22 16:44:18 +0000
@@ -0,0 +1,32 @@
1:orphan:
2
3utah manual page
4================
5
6Synopsis
7--------
8
9utah [-h] [--resume] [-s STATE_FILE] [-f {text,yaml,json}] [-t TESTDIR] [-r RUNLIST] [-o OUTPUT] [-a] [-d]
10
11Description
12-----------
13
14:program:`utah` executes a runlist and generates a file with the results
15
16Options
17-------
18-h, --help show this help message and exit
19--resume Continue a previous run. Used after a reboot
20-s STATE_FILE, --state-file STATE_FILE
21 File to use for storing state (default
22 "/var/lib/utah/state.yaml"
23-f <text,yaml,json>, --format <text,yaml,json>
24 Output format (default "yaml")
25-t TESTDIR, --testdir TESTDIR
26 Main test directory
27-r RUNLIST, --runlist RUNLIST
28 runlist file name
29-o OUTPUT, --output OUTPUT
30 write output to this file
31-a, --append append to output
32-d, --debug Print debugging output
033
=== modified file 'utah_howto.txt'
--- utah_howto.txt 2012-08-02 14:18:50 +0000
+++ utah_howto.txt 2012-08-22 16:44:18 +0000
@@ -60,7 +60,7 @@
60usage: utah [-h] [--resume] [-s STATE_FILE] [-f {text,yaml}] [-t TESTDIR]60usage: utah [-h] [--resume] [-s STATE_FILE] [-f {text,yaml}] [-t TESTDIR]
61 [-r RUNLIST] [-o OUTPUT] [-a] [-d]61 [-r RUNLIST] [-o OUTPUT] [-a] [-d]
6262
63Ubuntu Automation Testing Harness63Ubuntu Testing Automation Harness
6464
65optional arguments:65optional arguments:
66 -h, --help show this help message and exit66 -h, --help show this help message and exit

Subscribers

People subscribed via source and target branches

to all changes: