Merge lp:~javier.collado/utah/bug1025220 into lp:utah
Proposed by
Javier Collado
Status: | Merged |
---|---|
Merged at revision: | 456 |
Proposed branch: | lp:~javier.collado/utah/bug1025220 |
Merge into: | lp:utah |
Diff against target: |
137 lines (+38/-36) 3 files modified
examples/run_utah_tests.py (+7/-28) utah/provisioning/provisioning.py (+15/-8) utah/url.py (+16/-0) |
To merge this branch: | bzr merge lp:~javier.collado/utah/bug1025220 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Max Brustkern (community) | Approve | ||
Review via email: mp+115355@code.launchpad.net |
Description of the change
Initially I moved the URL checking code to the loop in utah/provisioni
However, after that, I thought that it would make more sense to use the `type` argument in argparse.
The validation code still lies in utah.url, but now it's called by argparse when parsing the arguments.
To post a comment you must log in.
Good idea. We can easily leverage that in future classes as well.