Code review comment for lp:~javier.collado/ubuntu-test-cases/bug1087630

Revision history for this message
Max Brustkern (nuclearbob) wrote :

The [ "$?" -eq "0" ] isn't really necessary. That's in the default preseed so that a latecommand will exist, and that particular command was chosen to avoid masking the exit status of the utah latecommand if no other latecommand is present. If another latecommand is present, that doesn't really serve a purpose. That said, it doesn't hurt anything either.

Also, /var/log/utah-install is used for other things which can come before or after this use. It doesn't look to me like the current code will detect the correct line and not just the first line of the file, but I could be wrong about that.

review: Needs Information

« Back to merge proposal