Merge lp:~javier.collado/testtools/isdivisible-typos into lp:testtools

Proposed by Javier Collado
Status: Needs review
Proposed branch: lp:~javier.collado/testtools/isdivisible-typos
Merge into: lp:testtools
Diff against target: 24 lines (+3/-3)
1 file modified
doc/for-test-authors.rst (+3/-3)
To merge this branch: bzr merge lp:~javier.collado/testtools/isdivisible-typos
Reviewer Review Type Date Requested Status
testing-cabal Pending
Review via email: mp+169182@code.launchpad.net

Description of the change

This branch fixes a few typos in the documentation related to the
`IsDivisibleBy` matcher example.

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

Thanks for the patch Javier!

We don't use Launchpad to host the code for testtools any more. These days, our code is at <https://github.com/testing-cabal/testtools>. If you could resubmitting this patch there, that would make things much easier for us.

If you'd rather not, we'll still try to get around to reviewing and (hopefully!) merging this patch soon.

Thanks again,
jml

Revision history for this message
Javier Collado (javier.collado) wrote :

No problem, I'll resubmit in github. Thanks for letting me know.

Unmerged revisions

366. By Javier Collado

Fixed a few typos in the documentation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'doc/for-test-authors.rst'
--- doc/for-test-authors.rst 2013-05-12 09:32:06 +0000
+++ doc/for-test-authors.rst 2013-06-13 12:33:28 +0000
@@ -807,7 +807,7 @@
807matcher based on it::807matcher based on it::
808808
809 def test_divisible_numbers(self):809 def test_divisible_numbers(self):
810 IsDisivibleBy = MatchesPredicateWithParams(810 IsDivisibleBy = MatchesPredicateWithParams(
811 divisible, '{0} is not divisible by {1}')811 divisible, '{0} is not divisible by {1}')
812 self.assertThat(7, IsDivisibleBy(1))812 self.assertThat(7, IsDivisibleBy(1))
813 self.assertThat(7, IsDivisibleBy(7))813 self.assertThat(7, IsDivisibleBy(7))
@@ -880,9 +880,9 @@
880880
881 def test_is_divisible_by_example(self):881 def test_is_divisible_by_example(self):
882 # This succeeds, since IsDivisibleBy(5).match(10) returns None.882 # This succeeds, since IsDivisibleBy(5).match(10) returns None.
883 self.assertThat(10, IsDivisbleBy(5))883 self.assertThat(10, IsDivisibleBy(5))
884 # This fails, since IsDivisibleBy(7).match(10) returns a mismatch.884 # This fails, since IsDivisibleBy(7).match(10) returns a mismatch.
885 self.assertThat(10, IsDivisbleBy(7))885 self.assertThat(10, IsDivisibleBy(7))
886886
887The mismatch is responsible for what sort of error message the failing test887The mismatch is responsible for what sort of error message the failing test
888generates. Here's an example mismatch::888generates. Here's an example mismatch::

Subscribers

People subscribed via source and target branches

to all changes: