Code review comment for lp:~javier.collado/checkbox/bug990075-2

Revision history for this message
Javier Collado (javier.collado) wrote :

@Brendan

Thanks for your feedback. I agree on that it's safer to force the user to fix the whitelist before using checkbox, but I also think that it's difficult to make things work that way now that checkbox has been reordering jobs for quite a long time. What I mean is that users are already used to let checkbox fix things without worrying too much and things get a little bit more complex, then the feedback probably isn't going to be positive.

For now, what I believe is the right choice is to implement this feature which just provides some warning message to users, so that they decide if they want to fix their whitelist or let checkbox do it. Depending on the feedback received, the feature can be turned into something stricter or not, but let the users decide (we might be wrong in our judgment).

Anyway, it's true that a tool can be created to provide real help on the whitelist creation. Given that checkbox-editor already does that, after this fix is submitted, I'll work on improving the whitelist creation feature in checkbox-editor to avoid some of the issues found in the whitelists that have been created with it.

« Back to merge proposal