Code review comment for lp:~javier.collado/checkbox-core/staticmethods

Revision history for this message
Marc Tardif (cr3) wrote :

This is definately in the right direction where I would eventually like to see class methods replaced with static methods, and static methods replaced by functions. This would be consistent with what Guido said [1]: Ironically, there are now no known uses for class methods in the Python distribution (other than in the test suite). I might even get rid of classmethod in a future release if no good use for it can be found!

However, these changes should not be done systematically; if a class method doesn't happen to use the class argument, that doesn't necessarily mean it makes sense to make it a function. So, some class methods might make more sense to be expressed as just methods whereas others as functions.

1. http://www.python.org/download/releases/2.2/descrintro/

review: Approve

« Back to merge proposal