Code review comment for lp:~javier-lopez/ubuntu/trusty/wicd/fix-1132529

Revision history for this message
Javier López (javier-lopez) wrote :

> > If it's required I'll add it =)
>
> We would prefer that you did. In this case, the value of your "Forwarded"
> field would have helped me :)
>
> I don't think it's reasonable to land a patch in Ubuntu without somebody
> testing it.

I've tested it on Ubuntu trusty, I've not test it on Debian, that's what I was referring me to =)

>
> > I've previous bad experience in debian
>
> Remember that in Debian each package has its own maintainer or sets of
> maintainers. Unless you have had a bad experience with the wicd maintainers
> specifically, you shouldn't take your experience to mean much in this case.
>
> We can be pragmatic about this. If the (tested) fix gets ignored upstream,
> then we can link to the bug from our bug, and make the change ahead of it
> being looked at upstream to help Ubuntu users. But we should, at the minimum,
> have offered the patch upstream and documented this reason for introducing an
> Ubuntu delta in the bug.

Yes, it sounds reasonable, I've forwarded the patch to upstream:

https://code.launchpad.net/~chilicuil/wicd/wicd/+merge/198057

Thanks again for your comments

« Back to merge proposal