Merge lp:~jassmith/desktop-switcher/no-maximize into lp:desktop-switcher

Proposed by Jason Smith
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jassmith/desktop-switcher/no-maximize
Merge into: lp:desktop-switcher
Diff against target: None lines
To merge this branch: bzr merge lp:~jassmith/desktop-switcher/no-maximize
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
David Barth (community) Abstain
Review via email: mp+10967@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :
Revision history for this message
David Barth (dbarth) wrote :

The code seems ok, but i'd like Neil to confirm it's the only thing required to fix this bug.

review: Abstain
Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks good, as per bug. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/main.c'
--- src/main.c 2009-08-17 11:14:08 +0000
+++ src/main.c 2009-09-01 10:00:21 +0000
@@ -52,6 +52,7 @@
52#define NAUTILUS_SHOW_DESKTOP "/apps/nautilus/preferences/show_desktop"52#define NAUTILUS_SHOW_DESKTOP "/apps/nautilus/preferences/show_desktop"
53#define THEME "/desktop/gnome/interface/gtk_theme"53#define THEME "/desktop/gnome/interface/gtk_theme"
54#define MAXIMUS "/apps/maximus/undecorate"54#define MAXIMUS "/apps/maximus/undecorate"
55#define MAXIMUS_NO_MAXIMIZE "/apps/maximus/no_maximize"
5556
56#define GCONF_STOP "gconftool-2 --shutdown"57#define GCONF_STOP "gconftool-2 --shutdown"
57#define GCONF_UNSET "gconftool-2 --recursive-unset /apps/panel"58#define GCONF_UNSET "gconftool-2 --recursive-unset /apps/panel"
@@ -394,6 +395,17 @@
394 g_error_free (error);395 g_error_free (error);
395 error = NULL;396 error = NULL;
396 }397 }
398
399 /* Set maximus no_maximize */
400 error = NULL;
401 gconf_client_set_bool (client, MAXIMUS_NO_MAXIMIZE, FALSE, &error);
402 if (error)
403 {
404 g_warning ("Can't change Maximus's no maximize setting: %s",
405 error->message);
406 g_error_free (error);
407 error = NULL;
408 }
397409
398 /* Launch the launcher */410 /* Launch the launcher */
399 g_debug ("Launching the, er, Launcher");411 g_debug ("Launching the, er, Launcher");
@@ -511,6 +523,17 @@
511 g_error_free (error);523 g_error_free (error);
512 error = NULL;524 error = NULL;
513 }525 }
526
527 /* Set maximus no_maximize */
528 error = NULL;
529 gconf_client_set_bool (client, MAXIMUS_NO_MAXIMIZE, TRUE, &error);
530 if (error)
531 {
532 g_warning ("Can't change Maximus's no maximize setting: %s",
533 error->message);
534 g_error_free (error);
535 error = NULL;
536 }
514537
515 /* Kill any version of the launcher. */538 /* Kill any version of the launcher. */
516 g_debug ("Killing the launcher");539 g_debug ("Killing the launcher");

Subscribers

People subscribed via source and target branches

to all changes: