Code review comment for ~jasonzio/cloud-init:fixmounterrormatch
Revision history for this message
| Jason Zions (jasonzio) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> I like getting test coverage to explain what 'mocked' expectation are and why
> to give future-us context on what to worry about with a change.
>
>
> How's this patch look?
That looks pretty good to me. It trades off mocking the entire body of the error message in favor of mocking the only part that gets looked at. As long as that last statement is true (i.e. no code examining a failed mount attempt looks at anything but the captured Stderr part), you nicely capture the platform distinction and make sure we don't screw it up in the future.