Code review comment for lp:~jason-hobbs/maas/use-key-text

 * hard coded 'trusty' seems wrong in multiple places
 * you replaced what *was* a public key in
   apt-setup/local0/key
   with a keyring. Does something under the covers just handle either?

   Will updates to that repo work ? ie, will the key be installed
   into the target system properly?

 * test "$expected_sha256" = "$actual_sha256"
   no one is going to be able to look at a log and see what went wrong here
   this is repeated line again with the udeb.

 * it'd be nice to have some doc on how you make a keyring from a key
   to reduce the unfriendly binary content in the drivers.yaml file.

   Also, info on how to list what key is in that keyring.

 * i wonder if upgrades work (replacement of 'key' and 'key_binary' in third_party_drivers.py)

 * modprobe <driver>
   what if the driver is already loaded ? (which is likely if the booted kernel
   contains this driver).