Code review comment for lp:~janosch-peters-deactivatedaccount/widelands/bugfix_1395238

Revision history for this message
SirVer (sirver) wrote :

Yes, we are not caring about backwards compatibility between b18 and b19 - for the first time in Wideland's history. That allowed us to clean out some of the cruft we had in the code base. But that has bitten you here.

The code lgtm. I am a bit concerned that now many soldiers can rush through tight spots and overwhelm an opponent instead of going through one by one - that might attacks stronger. But if that is a real concern must be seen through in-game experience.

@bunnybot merge

review: Approve

« Back to merge proposal