Code review comment for lp:~janosch-peters-deactivatedaccount/widelands/bugfix_1395238

Revision history for this message
GunChleoc (gunchleoc) wrote :

I couldn't test if this works, but the code seems OK. Just one code style nit: We are moving away from using defines and using constexpr instead. So, instead of

    #define BLOCK_COUNT_IS_STUCK 10

it would be better to use something like:

    constexpr int kBlockCountIsStuck = 10;

The type should match state.ivar3.

« Back to merge proposal